-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite): remove server exports from resource routes #7828
fix(vite): remove server exports from resource routes #7828
Conversation
🦋 Changeset detectedLatest commit: acc17a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8f2788b
to
68ef921
Compare
|
||
// grep for server-only values in client assets | ||
let result = shell | ||
.grep("-l", /SERVER_ONLY_1|SERVER_ONLY_2/, assetFiles) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be simplified to target just "SERVER_ONLY"
for both exports rather than numbering them? Makes modifying this test less error prone.
@@ -632,20 +632,6 @@ export const remixVitePlugin: RemixVitePlugin = (options = {}) => { | |||
|
|||
let serverExports = ["loader", "action", "headers"]; | |||
|
|||
let routeExports = await getRouteModuleExports( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that the route transform doesn't need to run this anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback, nothing blocking. Looks great 👍
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Fixes #7795
Testing Strategy
Added integration cases to
vite build
test checking that server values get removed from client, and that build succeeds without errors referring to server code.Test was failing before the change, and passes now